Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defmulti's attr-map? parameter is ignored in analysis #1310

Closed
serioga opened this issue Jun 29, 2021 · 0 comments
Closed

defmulti's attr-map? parameter is ignored in analysis #1310

serioga opened this issue Jun 29, 2021 · 0 comments
Projects

Comments

@serioga
Copy link

serioga commented Jun 29, 2021

version

2021.06.18

macro usage

clojure.core/defmulti (macro)
[name docstring? attr-map? dispatch-fn & options]

platform

Windows 10, native.

problem

Metadata from the parameter attr-map? of the clojure.core/defmulti is ignored.

repro

(ns defmulti-deprecated)

(defmulti deprecated-multi1
  "Docstring"
  {:private true :deprecated true}
  identity)

(defmulti ^{:private true :deprecated true} deprecated-multi2
  "Docstring"
  identity)

(defn deprecated-fn
  "Docstring"
  {:private true :deprecated true}
  []
  nil)

(comment
  (deprecated-multi1)
  (deprecated-multi2)
  (deprecated-fn))
clj-kondo --lint src;dev
dev\defmulti_deprecated.clj:20:3: warning: #'defmulti-deprecated/deprecated-multi2 is deprecated
dev\defmulti_deprecated.clj:21:3: warning: #'defmulti-deprecated/deprecated-fn is deprecated
linting took 3045ms, errors: 0, warnings: 2

expected behavior

I would like to see warning that #'defmulti-deprecated/deprecated-multi1 is deprecated as well.

@borkdude borkdude added this to Needs triage in clj-kondo via automation Jun 29, 2021
@borkdude borkdude moved this from Needs triage to High priority (next release) in clj-kondo Jun 29, 2021
@borkdude borkdude moved this from High priority (next release) to Medium priority (new / enhance) in clj-kondo Jul 28, 2021
@borkdude borkdude moved this from Medium priority (new / enhance) to High priority (next release) in clj-kondo Aug 30, 2021
clj-kondo automation moved this from High priority (next release) to Done Aug 30, 2021
borkdude added a commit that referenced this issue Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
clj-kondo
  
Done
Development

No branches or pull requests

2 participants