Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about single arg use when there's a second arg in a reader conditional #1914

Closed
mk opened this issue Dec 14, 2022 · 0 comments · Fixed by #1915
Closed

Don't warn about single arg use when there's a second arg in a reader conditional #1914

mk opened this issue Dec 14, 2022 · 0 comments · Fixed by #1915

Comments

@mk
Copy link
Contributor

mk commented Dec 14, 2022

The following code in a cljc file

(let [scope *ns*]
  (or (#{:default} scope)
      #?(:clj (keyword? scope))))

Gives warning: Single arg use of or always returns the arg itself

Rewriting this is tedious and the macro expand also will generate the optimal code so it might be better to not warn at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant