If a namespace matches multiple :ns-groups, only :config-in-ns rules for the first are applied

[camsaul]

version

clj-kondo v2022.12.10

platform

Native

problem

If a namespace matches multiple groups in :ns-groups, only rules for the first matching config for :config-in-ns are applied

repro

Here is a minimal repo.

File src/x/core.clj:

(ns x.core)

(defn x []
  (eval "WOW")
  (println "OK")
  (printf "NICE\n"))

Config version 1:

{:linters
 {:discouraged-var
  {clojure.core/eval {:message "Please don't eval stuff"}}}

 :ns-groups
 [{:pattern "^x\\.core.*$"
   :name    core-namespaces}
  {:pattern "^x\\..*$"
   :name    x-namespaces}]

 :config-in-ns
 {core-namespaces
  {:linters
   {:discouraged-var
    {clojure.core/println {:message "Use log"}}}}

  x-namespaces
  {:linters
   {:discouraged-var
    {clojure.core/printf {:message "Use logf"}}}}}}

$ clj-kondo --lint src/
src/x/core.clj:4:3: warning: Please don't eval stuff
src/x/core.clj:5:3: warning: Use log
linting took 4ms, errors: 0, warnings: 2

Config version 2:

{:linters
 {:discouraged-var
  {clojure.core/eval {:message "Please don't eval stuff"}}}

 :ns-groups
 [{:pattern "^x\\..*$"
   :name    x-namespaces}
  {:pattern "^x\\.core.*$"
   :name    core-namespaces}]

 :config-in-ns
 {core-namespaces
  {:linters
   {:discouraged-var
    {clojure.core/println {:message "Use log"}}}}

  x-namespaces
  {:linters
   {:discouraged-var
    {clojure.core/printf {:message "Use logf"}}}}}}

$ clj-kondo --lint src/
src/x/core.clj:4:3: warning: Please don't eval stuff
src/x/core.clj:6:3: warning: Use logf
linting took 4ms, errors: 0, warnings: 2

Note that neither version provides all three warnings I'd expect; depending on the order of the :ns-groups, we either get the Use log or Use logf warning, but never both

config

See above

expected behavior

The configs from all matching :config-in-ns should be merged together. Failing that, Kondo should issue a warning that a namespace matches multiple groups and it is not supported.