Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint error with set/project not accepting seqable collection for ks #2143

Closed
frwdrik opened this issue Jul 16, 2023 · 1 comment
Closed

Lint error with set/project not accepting seqable collection for ks #2143

frwdrik opened this issue Jul 16, 2023 · 1 comment

Comments

@frwdrik
Copy link

frwdrik commented Jul 16, 2023

version

Using [com.github.clj-kondo/lein-clj-kondo 2023.07.13]

platform

Leiningen 2.10.0 on Java 17.0.7 OpenJDK 64-Bit Server VM

problem

The following gives a lint error "Expected: sequential collection, received: set":

(set/project [{:foo :bar}] #{:foo})

repro

(ns user
  (:require [clojure.set :as set]))

(set/project [{:foo :bar}] #{:foo})
clj-kondo --lint repro.clj
repro.clj:4:28: error: Expected: sequential collection, received: set.
linting took 22ms, errors: 1, warnings: 0

expected behavior
I expected no lint errors. The reason being that set/project will accept any seqable collection as last argument. The tests for set/project in Clojure itself passed a set as last arg: https://github.com/clojure/clojure/blob/501348deb1e49736f3c49f2c177bcff947fe3a17/test/clojure/test_clojure/clojure_set.clj#L142.
Happy to provide a PR :)

@frwdrik frwdrik changed the title Lint error with set/project not accepting seqable collection Lint error with set/project not accepting seqable collection for ks Jul 16, 2023
@borkdude
Copy link
Member

Fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants