Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema.core/defmethod linting for vectors dispatch-values #1175

Merged
merged 2 commits into from Feb 20, 2021

Conversation

leoiacovini
Copy link
Contributor

Closes: #1174

--

I preferred to go with the approach to track the fn-sym and index instead of trying to infer when the vector was supposed to be the arguments or the dispatch value (for any schema.core macro) because the inferring logic was going to be more complex (in the code or even computationally) and would probably still have some bugs in corner cases when using the :- keyword inside function bodies

@borkdude
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schema.core/defmethod linting error when dispatch-val is a vector
2 participants