Fix schema.core/defmethod linting for vectors dispatch-values #1175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1174
--
I preferred to go with the approach to track the
fn-sym
andindex
instead of trying to infer when the vector was supposed to be the arguments or the dispatch value (for any schema.core macro) because the inferring logic was going to be more complex (in the code or even computationally) and would probably still have some bugs in corner cases when using the:-
keyword inside function bodies