[analysis] Improve keyword reg support for re-frame #1266
Conversation
|
@borkdude not sure we need to add the |
src/clj_kondo/impl/hooks.clj
Outdated
| @@ -19,9 +19,9 @@ | |||
|
|
|||
| (defn reg-keyword! | |||
| ([k] | |||
| (reg-keyword! k true)) | |||
| (reg-keyword! k nil)) | |||
There was a problem hiding this comment.
it didn't seem right to register the keyword as a :reg true if user just reg-keyword! :kw without the intention of register that keyword as a definition, for those cases the 2 arity seems the correct approach.
There was a problem hiding this comment.
Yes, so this arity can be removed? Would it be useful for LSP to also have ref-keyword so you can find if re-frame.core/subscribe or re-frame.core/dispatch (specifically one of those) uses the keyword? Or is this covered by find-references well enough?
There was a problem hiding this comment.
Yeah, it's not necessary, the find references seems enough
There was a problem hiding this comment.
@borkdude not sure we should remove the 1 arity, imagine user wants to reg a keyword but not necessarily it's a keyword that is a definition, so just (reg-keyword! :my-key) looks valid, otherwise user would always register the keyword with the :def
There was a problem hiding this comment.
Why would a user ever want to "register" a keyword without any context? And didn't you rename that key to :reg?
There was a problem hiding this comment.
ops, yeah, :reg 😅.
You are right, if user don't register it, clj-kondo will reg as a normal keyword anyway.
I'll remove it so
ericdallo
changed the title
|
Tested with clojure-lsp and with this we have |
|
@ericdallo Looks awesome! Could you add one more test for the |
|
Done @borkdude! |
Fixes #1159
:def->:regre-frame.corefunctions that register a keyword as definition.