Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filename-pattern on ns-group #1793

Merged
merged 2 commits into from Sep 4, 2022

Conversation

ericdallo
Copy link
Member

Fixes #1790

Please answer the following questions and leave the below in as part of your PR.

@borkdude
Copy link
Member

borkdude commented Sep 4, 2022

Looks good, I wonder if this works on Windows too using the same regex.

@ericdallo
Copy link
Member Author

ericdallo commented Sep 4, 2022

@borkdude good catch, maybe I can simplify the regex in the test

@borkdude
Copy link
Member

borkdude commented Sep 4, 2022

Isn't that just hiding the problem? I think those regexes should work for *nix and Windows, else you would have to write some pretty hairy regexes to target both. We already have similar regexes for :output {:exclude-file ...}.

@borkdude
Copy link
Member

borkdude commented Sep 4, 2022

Hmm, since we don't have support for this in :exclude-files either, we will address that when necessary. So this PR is sufficient imo.

@borkdude borkdude merged commit 27a1298 into clj-kondo:master Sep 4, 2022
@ericdallo ericdallo deleted the add-ns-group-filename-pattern branch September 4, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support :file-pattern on :ns-group
2 participants