Issue 25 - data driven require.clj pathway #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has 2 failing tests on my machine. Setting up travis to catch these automatically. |
|
That’s a great idea. Let me know how you set it up and I can assist with setting up a local testing harness that matches Travis. |
|
IT should be good now. Travis should check the PR's automatically I think by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #25
Light overhaul -- mostly just decomposing large codeblocks into smaller functions and trying to separate functions from procedures -- no (intentional) change in actual logic.
More tests to follow. Want to get this in before too much moves around in
require.clj.