Refactor how HTML body is created in coerce-body helpers #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it is simpler and it seems unlikely that we would need any other "transformer" than for HTML. We should perhaps rename |
|
@holyjak please merge if you think this is good. I skipped the renaming for now for the lack of any good name ideas 😛 |
holyjak
approved these changes
Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at that code to understand the search issue I had a bit of a hard time understanding what the
transformeris actually doing. It is passed down very far and in many places augmented/changed slightly making overall program flow a little hard to understand (to me).I'm pretty sure there are still issues with this PR, particularly the
show-buildinterceptor may need some touching up, but I wanted to open this just to get your thoughts on the general refactoring @holyjak.