Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break down docset search by section headings #616

Merged
merged 1 commit into from Apr 25, 2022

Conversation

lread
Copy link
Member

@lread lread commented Apr 25, 2022

No longer defaulting to generic parsing for markdown docs.
This means the lovely code that parses section headings out is now invoked.

Replaced generic doc parsing with asciidoc specific parsing.
So we now cover both our rendered document format types.

Now collecting text via JSoup nodes instead of JSoup elements.
JSoup elements skips text only nodes.

Bump the client side index version to force refetch.

Closes #592

No longer defaulting to generic parsing for markdown docs.
This means the lovely code that parses these out is now invoked.

Replaced generic doc parsing with asciidoc specific parsing.
So we now cover both our rendered document format types.

Now collecting text via JSoup nodes instead of JSoup elements.
JSoup elements skips text only nodes.

Bump the client side index version to force refetch.

Closes cljdoc#592
Copy link
Contributor

@corasaurus-hex corasaurus-hex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! A couple questions but otherwise I'd merge this.

src/cljdoc/render/api_searchset.clj Show resolved Hide resolved
src/cljdoc/render/api_searchset.clj Show resolved Hide resolved
@lread lread merged commit 735d98a into cljdoc:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out why single docset search isn't breaking down doc results by section header
2 participants