Issue 102. Fixed combo-box items update. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Released 1.7.12 with your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#102
Replacing list items in a
ComboBoxviaObservableList/setAll(ie,combox.getItems().setAll(...)) causes the selected item to be lost by the underlying JavaFX component state. Using theComboBox's.setItemmethod directly fixes the issue.This PR configures cljfx/combo-box to use the direct component setter instead of the observable list update.
A private
observable-listcoercion function is relocated to thecoercenamespace so that it can be used bycombo-box.I've tested that this fixes the issue and ran the unit tests via
clj -M:test:runner.(Let me know if you'd like any changes, additions, tests to this PR.)