treat missing entries in context as nil entries #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: adding new entries to the root of the context
doesn't trigger rerenderings.
See `cljfx.context-test.empty-context` for a minimal
example.
Solution: improve cache invalidation logic to recognize
newly added keys. These two old-map/new-map cases now
behave identically:
{:foo nil} => {:foo 1}
{} => {:foo 1}
frenchy64
force-pushed
the
context-missing-entry
branch
from
fcc28db
to
0d57bcd
Compare
|
Forced push uses |
This was referenced Jul 29, 2019
|
Great find! I wasn't expecting people to be actively exploring context stuff 😊 Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Adding new entries to the root of the context doesn't trigger rerenderings.
See
cljfx.context-test.empty-contextfor a minimal example.Notice "x1" is skipped after dissoc:
Solution
Improve cache invalidation logic to recognize newly added keys. These two old-map/new-map cases now behave identically:
{:foo nil} => {:foo 1} {} => {:foo 1}Final result: "x1" is shown after dissoc
