Misc. test fixes #25
Merged
Misc. test fixes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
cljoly
commented
Nov 12, 2022
cljoly
commented
- docs: fix doc tests
- chore: fix clippy warning
It seems that with recent Rust versions (introduction of GAT?) combined with old rusqlite versions (for instance 0.23.0), the compiler gets lost here if we don’t use a type for the arguments of execute.
With recent versions of rusqlite, a borrow became useless. But it’s not quite worth incrementing the minimum required rusqlite version, so silence this particular warning in this particular place for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.