Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems and improve tests according to cargo mutants #47

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

czocher
Copy link
Collaborator

@czocher czocher commented Mar 14, 2023

This PR fixes problems found by mutation testing.

  • Asynch module is not fixed yet

Fixes #46 and #45.
Partially implements #40.

@czocher czocher force-pushed the mutation-testing-fixes branch 3 times, most recently from 35a09eb to f12882c Compare March 15, 2023 13:28
@czocher
Copy link
Collaborator Author

czocher commented Mar 15, 2023

@cljoly you can review this PR.

Copy link
Owner

@cljoly cljoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve taken a quick look and shared some preliminary comments.

Thanks a lot for expending the test coverage and finding all those bugs with mutants!

.gitignore Show resolved Hide resolved
rusqlite_migration/src/tests.rs Outdated Show resolved Hide resolved
rusqlite_migration/src/lib.rs Show resolved Hide resolved
rusqlite_migration/src/tests/synch.rs Outdated Show resolved Hide resolved
@czocher
Copy link
Collaborator Author

czocher commented Mar 17, 2023

Fixed the PR according to your review. Thanks!

@cljoly
Copy link
Owner

cljoly commented Mar 17, 2023

Looks all good to me, thanks for your work on this!

@cljoly cljoly merged commit 3845b1c into cljoly:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug-format on MigrationHook causes a stack overflow
2 participants