Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to externs free libraries #23

Closed
jeluard opened this issue Mar 2, 2015 · 4 comments
Closed

Add support to externs free libraries #23

jeluard opened this issue Mar 2, 2015 · 4 comments

Comments

@jeluard
Copy link
Contributor

jeluard commented Mar 2, 2015

Some libraries do not need externs to properly work. A canonical example is a polyfill library whose associated externs are already in closure compiler.

Let me know if this is desirable. I have a patch for this.
@martinklepsch
Copy link
Member

Good point. What kind of patch do you have in mind?

@jeluard
Copy link
Contributor Author

jeluard commented Mar 2, 2015

Simply removing the check on externs and not including it in deps.cljs. It appears to work fine. Am I missing something?

@martinklepsch
Copy link
Member

Maybe we should introduce a flag --no-externs so we it's a little more explicit and we still keep the validation helpers for the common case of packaging libs with extern files?

@jeluard
Copy link
Contributor Author

jeluard commented Mar 2, 2015

Sounds good I'll do that.

martinklepsch pushed a commit that referenced this issue Mar 14, 2015
Merge pull request #24 from jeluard/no-externs
0fed362 
Added :no-externs option to deps-cljs task. Fixes #23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinklepsch @jeluard