Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asset-minifier to allow es6 minification #53 #54

Conversation

rangeoshun
Copy link

@rangeoshun rangeoshun commented Oct 18, 2018

This PR changes the interface a bit but solves #53.

Generally, it should be backward compatible, as in updates to packages are only needed in minify opts.

:lang -> :lang-in

The ES6 input should be still OK for all packages.

Notes, objections?

@rangeoshun
Copy link
Author

I could rename lang-in to the old lang if that is more acceptable, but would lack the consistency.

@rangeoshun
Copy link
Author

One note tho, the description for the language argument was saying that the default languga is ES3, but I think it was not true since a long time.

@Deraen Deraen merged commit 4eff849 into cljsjs:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants