-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moment.js extern is out of date #6
Comments
Looks like putting the moment.js through Closure compiler will break it even with proper extern file. Perhaps it would not be too big work to create cljs.core test going through documented api of Moment. |
Is this still the case? Haven't we straightened it out with eg cljsjs/moment 2.9.0-0 ? If so, can we close this? |
The extern is still based on Moment 2.6.0 externs. At the least the following changes would require changes to the extern file: 2.7.0
(2.8.0
2.8.2
2.9.0
It's easy to implement the changes but they would require some, perhaps manual, testing. |
Ah ok right; when the next version bump happens from moment I will take the opportunity to revisit this. |
+1 for a fix, would like to include the latest moment.js using cljsjs. |
Just wanted to use moment.js — but I'll hold off and wait for a fix. |
@jwr, I think there are quite many people using moment.js already even though the extern is not perfect. It's probable that the extern won't be improved unless some user creates a PR about this, I'm not using Moment.js myself. Points in my previous comment should still hold and provide a starting point for checking what is broken with the extern. |
@Deraen thanks. I'll use it, then — and if I hit breakage, I'll try to fix it. |
port vega component from om to reagent
Moment.ext.js is, based on comment, for 2.0.0. But it looks to me that it doesn't include even all functions that moment.js 2.0.0 does.
I added some fixes but I'm thinking that there should be some way to test the extern file.
I wonder if it would might be possible to run moment code through closure compiler and then run their unittests against that.
The text was updated successfully, but these errors were encountered: