New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incremental-dom] - Add incremental dom #361
Conversation
Hmm, interesting. CI should support Node and npm. I would like to check if we can get ClojureScript to support I think without patch there is no need to use Make. |
Adding Cljs support for |
I've added a pull request which uses As an alternative, the original library is written using ES2015 modules, and also has gulp tasks to compile to CommonJS and AMD modules. I don't think any of those module systems are supported in the clojurescript compiler either, but if there's more impetus behind adding any of these it might be worth trying to integrate one of those options. |
I've just updated this to use just boot. It still uses the patched gulpfile, but I did enough reading around the boot api to get it to work without shelling out to |
Great! As adding support for Could you just fix the header in readme :) |
Fixed - cheers :) |
I did just once change, I added build identifier to version: Should be deployed now, there was some errors from gulp related to unit-phantom, but I don't know if that matters? Probably CI has older PhantomJS version or something like that. |
Sounds good, just tested it and it all seems to work as expected! Cheers Deraen |
Thanks for contributing the package! |
This adds incremental dom to cljsjs.
Incremental dom is google closure compiler compatible, so this package plays nicely with advanced compilation. However, the default incremental dom build uses goog.module to declare the namespace, which doesn't seem to be compatible with the clojurescript compiler's dependency resolution. I've included a patch for the incremental dom gulp file which outputs code which is compatible with the clojurescript compiler.
I'm not sure what the build server supports, but this will require nodejs and npm to build the library. If that's not supported, I'd welcome any suggestions as to the best way to get this into cljsjs.