Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build.boot to download and sift raw JS instead of zip so that loc... #96

Closed
wants to merge 1 commit into from

Conversation

hipitihop
Copy link
Contributor

Change build.boot to download and sift raw JS instead of zip so that local build works on Windows/Linux

Note: on Windows 7 previously boot package build-jar complains about not being able to delete the downloaded zip, and fails when sift regex has forward slashes in path. Using raw JS avoids this problem. I suspect other projects here may have similar issues under Windows.

@martinklepsch
Copy link
Member

@hipitihop I'd rather fix this "once-and-for-all" by changing boot-cljsjs to work smoothly on Windows. Would you be up for giving that a whirl? 😃

@hipitihop
Copy link
Contributor Author

Better windows support is welcome. Happy to help to be a guinea pig. I'm no Windows dev anymore, Ubuntu/Linux here with access to Win 7 VM, others on our team have Win so can also test.

On 13 April 2015 8:06:23 pm AEST, Martin Klepsch notifications@github.com wrote:

@hipitihop I'd rather fix this "once-and-for-all" by changing
boot-cljsjs to work smoothly on Windows. Would you be up for giving
that a whirl? 😃


Reply to this email directly or view it on GitHub:
#96 (comment)

@martinklepsch
Copy link
Member

I added an issue to the boot-cljsjs project and will close this PR for now.

@martinklepsch
Copy link
Member

@hipitihop please subscribe to the linked issue and let people know that you can try out things if that's still the case :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants