quoted version number in 5.39.1 causes error instead of no-op #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 5.39.1 passing an argument to a missing import is an error. When the version is quoted it is treated as an argument to import(), but perl special cases import so when it is missing it silently ignores the call entirely. (Exporter::import would do a version check.) Simply removing the quotes makes 5.39.1 happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting a version number means the parameter gets passed to import() instead of to VERSION(), and in 5.39.1 perl dies if an argument is passed to a missing import() as in this case. In older perls it was silently ignored. Thus this used to be a no-op.