Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release new versions with support up to 1.21 #22

Closed
6 tasks done
clo4 opened this issue May 8, 2024 · 5 comments
Closed
6 tasks done

Release new versions with support up to 1.21 #22

clo4 opened this issue May 8, 2024 · 5 comments
Labels
pack:afk Issues relating to Detect AFK Players pack:afk-dim-names Issues relating to AFK Dim Names pack:afk-message Issues relating to the AFK Message datapack pack:afk-sleep Issues relating to AFK Sleep pack:chickenfix Issues relating to Chickenfix pack:pause-day-cycle Issues relating to Pause Day Cycle

Comments

@clo4
Copy link
Owner

clo4 commented May 8, 2024 •
edited

  • AFK
  • AFK Dim Names
  • AFK Message
  • AFK Sleep
  • Chickenfix
  • Pause Day Cycle

Things I need to look into: how are other datapacks releasing versions where the only thing that changes is the version? Are they incrementing the version number? Are there other versioning systems that might solve this for me?
@clo4 clo4 added pack:afk-message Issues relating to the AFK Message datapack pack:afk Issues relating to Detect AFK Players pack:afk-dim-names Issues relating to AFK Dim Names pack:afk-sleep Issues relating to AFK Sleep pack:pause-day-cycle Issues relating to Pause Day Cycle pack:chickenfix Issues relating to Chickenfix labels May 8, 2024
@clo4
Copy link
Owner Author

clo4 commented May 13, 2024

Bumped versions in d885503. I don't have the energy right now to test all of them to guarantee it's going to work, though, much less to create the releases too. I might only update them for 1.21 because that's the version I'll be updating my own server to.

@clo4 clo4 changed the title Release new versions with support up to 1.20.6 Release new versions with support up to 1.21 Jun 10, 2024
@clo4
Copy link
Owner Author

clo4 commented Jun 10, 2024

I'm changing this goal to be 1.21 - even with the directory changes it's possible to support older versions thanks to the build script. Got some more thinking about that in #20.

I still need to test, but now I have to bump the versions again too. Build script support landed in 6e0f5eb

@clo4
Copy link
Owner Author

clo4 commented Jun 17, 2024 •
edited

Things I need to look into: how are other datapacks releasing versions where the only thing that changes is the version? Are they incrementing the version number? Are there other versioning systems that might solve this for me?

Going forward, here's how it's going to work:

  • The versioning of the pack is based on features, not game compatibility. Game version compatibility is encoded by the file name itself, not the version of the datapack itself.
  • Updates that do not introduce new features, for any reason, will be a patch update - this includes bumping the pack format. Dropping a support for a game version can be done in a patch, but dropping support for a feature cannot be done in a patch.
  • Introducing support for an older version in the same datapack ZIP is also a patch update. Introducing support for an older version in a way that requires a new ZIP file does not require a patch, as this will typically be done in a branch and not actively kept up to date.

Some examples:

  • With the 1.21 update, as I have not introduced any functionality changes, the versions will only bump the patch number.
  • When I introduce support for the next version after 1.21 (very likely 1.21.1 🙄) I will bump the patch again.

clo4 added a commit that referenced this issue Jun 17, 2024
@clo4
Fix pack versions
932dc0a 
The versions were getting out of sync with reality because I was
keeping track of it manually and version bumps were vibes-based.

I now have a standard way to consider version changes:
#22 (comment)
@clo4 clo4 mentioned this issue Jun 17, 2024
Merged
@clo4
Copy link
Owner Author

clo4 commented Jun 17, 2024

The PR is merged, now I just need to create the releases.

@clo4
Copy link
Owner Author

clo4 commented Jun 17, 2024

All released.

@clo4 clo4 closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pack:afk Issues relating to Detect AFK Players pack:afk-dim-names Issues relating to AFK Dim Names pack:afk-message Issues relating to the AFK Message datapack pack:afk-sleep Issues relating to AFK Sleep pack:chickenfix Issues relating to Chickenfix pack:pause-day-cycle Issues relating to Pause Day Cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clo4