Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new style union syntax #3

Merged
merged 1 commit into from Sep 25, 2023
Merged

Use new style union syntax #3

merged 1 commit into from Sep 25, 2023

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Sep 25, 2023

Update dependencies, use poetry groups
Add missing typing-extensions dependency

Update dependencies, use poetry groups
Add missing typing-extensions dependency
Copy link
Owner

@clo4 clo4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you once again! All looks good to me.

There's also an explicit union in effects.py, but I think it might be slightly more unclear what's going on by using the new syntax. I'll play with it and see.

Once I've tested this a little it should be good to go for a release tonight.

@Viicos
Copy link
Contributor Author

Viicos commented Sep 25, 2023

Thank you once again! All looks good to me.

There's also an explicit union in effects.py, but I think it might be slightly more unclear what's going on by using the new syntax. I'll play with it and see.

Once I've tested this a little it should be good to go for a release tonight.

Forgot about this one. Otherwise it is usually safe to use the new syntax for type stubs, as long as every major type checker uses it.

@clo4
Copy link
Owner

clo4 commented Sep 25, 2023

Both Mypy and Pyright support it, and those you can (and probably should) use the most up-to-date versions even on older projects, so I don't think it's a problem. Although it's been so long since I was in the Python ecosystem that I could be remembering entirely incorrectly 😂

@clo4 clo4 merged commit f8878fa into clo4:main Sep 25, 2023
@Viicos Viicos deleted the new-syntax branch September 25, 2023 11:57
@clo4
Copy link
Owner

clo4 commented Sep 25, 2023

I've published a new version now! You can grab it from pypi. Made sure to give you appropriate attribution - thank you so much for working on modernizing these stubs 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants