Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contractURI for nft collection metadata #34

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

graykode
Copy link
Contributor

@graykode graykode commented Apr 6, 2023

Create contractURI function for opensea

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c3a0c42) 99.27% compared to head (b0b7e82) 99.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files           9        9           
  Lines         550      553    +3     
  Branches      100      101    +1     
=======================================
+ Hits          546      549    +3     
  Misses          1        1           
  Partials        3        3           
Impacted Files Coverage Δ
contracts/OrderNFT.sol 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

This comment has been minimized.

@onemonster onemonster merged commit 2e25be0 into main Apr 7, 2023
10 checks passed
@onemonster onemonster deleted the feat/contract-url branch April 7, 2023 05:55
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Test with 62b39af.

  • EHET : Empty heap with empty segment tree
  • EHDT : Empty heap with dirty segment tree
  • FHET : Filled heap with empty segment tree
  • FHFT : Filled heap with filled segment tree

Changes to gas cost

Generated at commit: 62b39af66a492117282889a7c2f2dc2395fe8cf3, compared to commit: c3a0c423484d68fc93594b558bd02905f0e4fc5b

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
GasReporter contract FHFT_LimitAsk
FHFT_LimitBid
limitAskOrder
limitBidOrder
+111 ❌
+111 ❌
+106 ❌
+107 ❌
+0.09%
+0.09%
+0.14%
+0.13%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
GasReporter contract 948,376 (0) EHDT_FullyCancelAsk
EHDT_FullyCancelBid
EHDT_LimitAsk
EHDT_LimitBid
EHDT_PartiallyCancelAsk
EHDT_PartiallyCancelBid
EHET_FullyCancelAsk
EHET_FullyCancelBid
EHET_LimitAsk
EHET_LimitBid
EHET_PartiallyCancelAsk
EHET_PartiallyCancelBid
FHET_FullyCancelAsk
FHET_FullyCancelBid
FHET_LimitAsk
FHET_LimitBid
FHET_PartiallyCancelAsk
FHET_PartiallyCancelBid
FHFT_FullyCancelAsk
FHFT_FullyCancelBid
FHFT_LimitAsk
FHFT_LimitBid
FHFT_PartiallyCancelAsk
FHFT_PartiallyCancelBid
cancelOrder
limitAskOrder
limitBidOrder
121,741 (-22)
120,840 (-22)
143,854 (+111)
156,905 (+111)
153,353 (-22)
152,488 (-22)
121,675 (-22)
137,941 (-22)
260,987 (+111)
239,767 (+111)
170,520 (-22)
169,609 (-22)
121,697 (-22)
137,898 (-22)
187,249 (+111)
166,349 (+111)
125,271 (-22)
141,495 (-22)
121,676 (-22)
120,773 (-22)
121,535 (+111)
117,584 (+111)
125,293 (-22)
124,438 (-22)
40,756 (-17)
47,020 (+88)
44,845 (+89)
-0.02%
-0.02%
+0.08%
+0.07%
-0.01%
-0.01%
-0.02%
-0.02%
+0.04%
+0.05%
-0.01%
-0.01%
-0.02%
-0.02%
+0.06%
+0.07%
-0.02%
-0.02%
-0.02%
-0.02%
+0.09%
+0.09%
-0.02%
-0.02%
-0.04%
+0.19%
+0.20%
121,741 (-22)
120,840 (-22)
143,854 (+111)
156,905 (+111)
153,353 (-22)
152,488 (-22)
121,675 (-22)
137,941 (-22)
260,987 (+111)
239,767 (+111)
170,520 (-22)
169,609 (-22)
121,697 (-22)
137,898 (-22)
187,249 (+111)
166,349 (+111)
125,271 (-22)
141,495 (-22)
121,676 (-22)
120,773 (-22)
121,535 (+111)
117,584 (+111)
125,293 (-22)
124,438 (-22)
41,796 (-18)
74,654 (+106)
84,573 (+107)
-0.02%
-0.02%
+0.08%
+0.07%
-0.01%
-0.01%
-0.02%
-0.02%
+0.04%
+0.05%
-0.01%
-0.01%
-0.02%
-0.02%
+0.06%
+0.07%
-0.02%
-0.02%
-0.02%
-0.02%
+0.09%
+0.09%
-0.02%
-0.02%
-0.04%
+0.14%
+0.13%
121,741 (-22)
120,840 (-22)
143,854 (+111)
156,905 (+111)
153,353 (-22)
152,488 (-22)
121,675 (-22)
137,941 (-22)
260,987 (+111)
239,767 (+111)
170,520 (-22)
169,609 (-22)
121,697 (-22)
137,898 (-22)
187,249 (+111)
166,349 (+111)
125,271 (-22)
141,495 (-22)
121,676 (-22)
120,773 (-22)
121,535 (+111)
117,584 (+111)
125,293 (-22)
124,438 (-22)
42,836 (-18)
79,807 (+111)
96,988 (+111)
-0.02%
-0.02%
+0.08%
+0.07%
-0.01%
-0.01%
-0.02%
-0.02%
+0.04%
+0.05%
-0.01%
-0.01%
-0.02%
-0.02%
+0.06%
+0.07%
-0.02%
-0.02%
-0.02%
-0.02%
+0.09%
+0.09%
-0.02%
-0.02%
-0.04%
+0.14%
+0.11%
121,741 (-22)
120,840 (-22)
143,854 (+111)
156,905 (+111)
153,353 (-22)
152,488 (-22)
121,675 (-22)
137,941 (-22)
260,987 (+111)
239,767 (+111)
170,520 (-22)
169,609 (-22)
121,697 (-22)
137,898 (-22)
187,249 (+111)
166,349 (+111)
125,271 (-22)
141,495 (-22)
121,676 (-22)
120,773 (-22)
121,535 (+111)
117,584 (+111)
125,293 (-22)
124,438 (-22)
61,956 (-18)
215,207 (+111)
234,398 (+111)
-0.02%
-0.02%
+0.08%
+0.07%
-0.01%
-0.01%
-0.02%
-0.02%
+0.04%
+0.05%
-0.01%
-0.01%
-0.02%
-0.02%
+0.06%
+0.07%
-0.02%
-0.02%
-0.02%
-0.02%
+0.09%
+0.09%
-0.02%
-0.02%
-0.03%
+0.05%
+0.05%
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
294,912 (0)
245,784 (0)
245,784 (0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants