-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add registerPreviousMarkets
function to migrate previous markets
#35
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 99.27% 99.28% +0.01%
==========================================
Files 9 9
Lines 550 562 +12
Branches 100 103 +3
==========================================
+ Hits 546 558 +12
Misses 1 1
Partials 3 3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please allow the factory owner to unregister markets as well. Also, the word previous seems a bit redundant and unnecessary.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test with 51e4ae3.
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Features
Create
registerPreviousMarkets
function to support migrating previous marketsDescription:
This pull request adds a new function called
registerPreviousMarkets
to the codebase. This function supports migrating previous markets and will help ensure that market data is properly carried over to new versions of the code.