Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change some names #37

Merged
merged 5 commits into from
Apr 7, 2023
Merged

refactor: change some names #37

merged 5 commits into from
Apr 7, 2023

Conversation

graykode
Copy link
Contributor

@graykode graykode commented Apr 7, 2023

Refactoring some variable names

@graykode graykode changed the title refactor: change _maxPrice -> _priceUpperBound refactor: change some names Apr 7, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (4b94b5a) 98.59% compared to head (49120e2) 98.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files           9        9           
  Lines         568      568           
  Branches      104      104           
=======================================
  Hits          560      560           
  Misses          4        4           
  Partials        4        4           
Impacted Files Coverage Δ
contracts/OrderBook.sol 98.59% <0.00%> (ø)
contracts/markets/StableMarket.sol 75.00% <0.00%> (ø)
contracts/markets/VolatileMarket.sol 75.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@graykode graykode merged commit f696efc into main Apr 7, 2023
10 checks passed
@graykode graykode deleted the refactor/naming branch April 7, 2023 09:17
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Test with ef8e7bc.

  • EHET : Empty heap with empty segment tree
  • EHDT : Empty heap with dirty segment tree
  • FHET : Filled heap with empty segment tree
  • FHFT : Filled heap with filled segment tree
    No longer impact gas costs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants