-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement batch limit order at router #47
Conversation
JhChoy
commented
May 12, 2023
- Implement batch limit order logic at Router.
- Change refund logic to support batch order
This comment has been minimized.
This comment has been minimized.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
===========================================
- Coverage 98.81% 87.57% -11.24%
===========================================
Files 8 10 +2
Lines 589 684 +95
Branches 108 146 +38
===========================================
+ Hits 582 599 +17
- Misses 2 80 +78
Partials 5 5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test with e467575.
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|