Protobuf serialization should be done outside of a transaction #1024
Assignees
Comments
joshua-spacetime
added a commit
that referenced
this issue
Mar 26, 2024
Closes #1024. Before this change, we would serialize messages **before** inserting into the send queue. Because we commit the tx only after inserting into the send queue, this meant we were holding onto the database lock unnecessarily. After this change, we serialize messages **after** inserting into the send queue. This means we serialize only after committing the tx.
joshua-spacetime
added a commit
that referenced
this issue
Mar 26, 2024
Closes #1024. Before this change, we would serialize messages **before** inserting into the send queue. Because we commit the tx only after inserting into the send queue, this meant we were holding onto the database lock unnecessarily. After this change, we serialize messages **after** inserting into the send queue. This means we serialize only after committing the tx.
joshua-spacetime
added a commit
that referenced
this issue
Mar 26, 2024
Closes #1024. Before this change, we would serialize messages **before** inserting into the send queue. Because we commit the tx only after inserting into the send queue, this meant we were holding onto the database lock unnecessarily. After this change, we serialize messages **after** inserting into the send queue. This means we serialize only after committing the tx.
joshua-spacetime
added a commit
that referenced
this issue
Mar 26, 2024
Closes #1024. Before this change, we would serialize messages **before** inserting into the send queue. Because we commit the tx only after inserting into the send queue, this meant we were holding onto the database lock unnecessarily. After this change, we serialize messages **after** inserting into the send queue. This means we serialize only after committing the tx.
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Mar 27, 2024
Closes #1024. Before this change, we would serialize messages **before** inserting into the send queue. Because we commit the tx only after inserting into the send queue, this meant we were holding onto the database lock unnecessarily. After this change, we serialize messages **after** inserting into the send queue. This means we serialize only after committing the tx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we serialize messages while holding a tx handle, which means we're holding the database lock while performing serialization. Instead protobuf serialization should happen after the message has already been placed, i.e ordered, in the send queue.
The text was updated successfully, but these errors were encountered: