Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscriptions can send messages out of order #996

Closed
joshua-spacetime opened this issue Mar 20, 2024 · 0 comments · Fixed by #997
Closed

Subscriptions can send messages out of order #996

joshua-spacetime opened this issue Mar 20, 2024 · 0 comments · Fixed by #997
Assignees
@joshua-spacetime
Labels
bug Something isn't working

Comments

@joshua-spacetime
Copy link
Collaborator

The following ordering is currently possible

Initial subscription evaluated 
    -> Tx starts
    -> Tx commits
    -> updates for Tx sent to client
    -> updates for initial subscription sent to client

That is, it is possible for a transaction to execute and send its updates to the client after an initial subscription has been evaluated but before the initial subscription has sent its results to the client. This will result in the client receiving an inconsistent view of the database.
@joshua-spacetime joshua-spacetime self-assigned this Mar 20, 2024
@joshua-spacetime joshua-spacetime added the bug Something isn't working label Mar 20, 2024
joshua-spacetime added a commit that referenced this issue Mar 20, 2024
@joshua-spacetime
fix(996): Do not release database lock early for subscriptions
a8d1ae2 
Fixes #996.
@joshua-spacetime joshua-spacetime mentioned this issue Mar 20, 2024
Merged
2 tasks
joshua-spacetime added a commit that referenced this issue Mar 20, 2024
@joshua-spacetime
fix(996): Do not release database lock early for subscriptions
c79318e 
Fixes #996.
joshua-spacetime added a commit that referenced this issue Mar 20, 2024
@joshua-spacetime
fix(996): Do not release database lock early for subscriptions
48476ce 
Fixes #996.
@joshua-spacetime joshua-spacetime linked a pull request Mar 20, 2024 that will close this issue
fix(996): Do not release database lock early for subscriptions #997
Merged
2 tasks
joshua-spacetime added a commit that referenced this issue Mar 20, 2024
@joshua-spacetime
fix(996): Do not release database lock early for subscriptions
f2cc2fd 
Fixes #996.
joshua-spacetime added a commit that referenced this issue Mar 20, 2024
@joshua-spacetime
fix(996): Do not release database lock early for subscriptions
d2d5782 
Fixes #996.
github-merge-queue bot pushed a commit that referenced this issue Mar 20, 2024
@joshua-spacetime
fix(996): Do not release database lock early for subscriptions (#997)
b36dda4 
Fixes #996.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshua-spacetime joshua-spacetime

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(996): Do not release database lock early for subscriptions clockworklabs/SpacetimeDB
1 participant
@joshua-spacetime