Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoketest auto-disconnect after restart #1367

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Smoketest auto-disconnect after restart #1367

merged 2 commits into from
Jun 20, 2024

Conversation

kim
Copy link
Contributor

@kim kim commented Jun 11, 2024

(Re-)enables the zz-docker tests with some tweaking to increase the chances that a restart actually works.
Adds a smoketest which tests that clients are auto-disconnected after unclean shutdown.

Depends-on: #1343

@kim kim changed the title WIP: smoke test dangling clients after restart Smoketest auto-disconnect after restart Jun 12, 2024
@kim kim marked this pull request as ready for review June 12, 2024 06:29
@kim kim force-pushed the kim/smoke-dangling branch 2 times, most recently from 11b1645 to 8a4c162 Compare June 12, 2024 08:14
Base automatically changed from noa/subscribe-subcommand to master June 14, 2024 09:41
@kim kim force-pushed the kim/smoke-dangling branch 2 times, most recently from 5c5d80c to 35c546d Compare June 14, 2024 10:17
@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels Jun 17, 2024
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kim kim added this pull request to the merge queue Jun 20, 2024
Merged via the queue into master with commit 60c438d Jun 20, 2024
9 checks passed
@kim kim deleted the kim/smoke-dangling branch June 20, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no runtime change This change does not affect the final binaries release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a smoke test to confirm that clients get disconnected after a SpacetimeDB crash
3 participants