Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove already tracked subscription counter #1412

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

joshua-spacetime
Copy link
Collaborator

We already track subscription requests through the rdb_num_txns counter.

Expected complexity level and risk

1

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

We already track subscription requests through the rdb_num_txns counter.
@joshua-spacetime joshua-spacetime self-assigned this Jun 12, 2024
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@joshua-spacetime joshua-spacetime added this pull request to the merge queue Jun 13, 2024
Merged via the queue into master with commit 44832f2 Jun 13, 2024
8 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/chore/remove-unused-metrics branch June 13, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants