Fix auth regression #1413
Merged
Fix auth regression #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
cloutiertyler
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
This LGTM. For context to future me, the format of the token query param was introduced in #51 which was only meant for short lived tokens acquired through a long-lived token, just to create a websocket connection. We should evaluate whether this query param is still necessary, and what format it should be if it is.
NOTE: We should also consider only accepting it for the websocket route, as it was originally only meant as a short lived token for this route only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.