Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate tagged enums in C# client code #1421

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

RReverser
Copy link
Contributor

Description of Changes

Now that we use a shared BSATN runtime with C# modules, we can leverage our special TaggedEnum construct to support tagged enums in the client as well.

As a drive-by fix, also slightly simplifies TypeScript tagged enum output and marked C# TaggedEnum base record as abstract (since it shouldn't be constructed).

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

1

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Ran codegen tests and updated snapshots.

Now that we use a shared BSATN runtime with C# modules, we can leverage our special TaggedEnum construct to support tagged enums in the client as well.

As a drive-by fix, also slightly simplifies TypeScript tagged enum output and marked C# TaggedEnum base record as abstract (since it shouldn't be constructed).
@RReverser RReverser requested a review from gefjon June 13, 2024 15:49
@RReverser RReverser enabled auto-merge June 13, 2024 15:56
@gefjon
Copy link
Contributor

gefjon commented Jun 13, 2024

Thanks! For posterity, I asked Ingvar to do this because it's useful for #1077 , as it will allow us to use the CLI to codegen the websocket bindings.

@RReverser RReverser added this pull request to the merge queue Jun 13, 2024
Merged via the queue into master with commit 4b7eff6 Jun 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants