Include BSATN.Codegen in nuget pack #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously thought that this was not required. We were wrong.
RReverser
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Previously BSATN.Codegen was ignored during the
nuget packcommand. During the release preparation of v0.10.0, it was discovered that this is required by the SDK. This includes the change to start building that csproj when we build and release nuget packages.API and ABI breaking changes
n/a
Expected complexity level and risk
0 - Minimal Risk or Complexity. It is only a configuration change for nuget packages.
Testing
[x] This diff was used in the v0.10.0 release preparation and I was able to
nuget packand push this C# Project successfully.