Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tools/publish-crates.sh #1426

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Update tools/publish-crates.sh #1426

merged 2 commits into from
Jun 14, 2024

Conversation

bfops
Copy link
Contributor

@bfops bfops commented Jun 13, 2024

Description of Changes

Did my best to update tools/publish-crates.sh with the crates that seemed to be missing.

I have no idea if I did this correctly, but did my best to maintain them in order of how they depend on each other.

Expected complexity level and risk

1

Testing

This branch contains the version that @kurtismullins tested during the last deploy

@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels Jun 13, 2024
bfops pushed a commit that referenced this pull request Jun 13, 2024
Copy link
Collaborator

@kurtismullins kurtismullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bfops Here were the changes I ultimately needed to successfully publish to crates.io in the v0.10.0-beta tag. I haven't checked to see if they match yours in this PR; if so, feel free to let me know and I'll approve it so you can get it merged.

At the moment, I am shoulder-deep in this release.

-declare -a CRATES=("metrics" "primitives" "bindings-macro" "bindings-sys" "sats" "lib" "bindings" "vm" "client-api-messages" "core" "client-api" "standalone" "cli" "sdk")
+declare -a CRATES=("metrics" "primitives" "bindings-macro" "bindings-sys" "data-structures" "sats" "lib" "bindings" "table" "vm" "client-api-messages" "commitlog" "durability" "fs-utils" "snapshot" "core" "client-api" "standalone" "cli" "sdk")

@bfops
Copy link
Contributor Author

bfops commented Jun 14, 2024

@bfops Here were the changes I ultimately needed to successfully publish to crates.io in the v0.10.0-beta tag. I haven't checked to see if they match yours in this PR; if so, feel free to let me know and I'll approve it so you can get it merged.

At the moment, I am shoulder-deep in this release.

-declare -a CRATES=("metrics" "primitives" "bindings-macro" "bindings-sys" "sats" "lib" "bindings" "vm" "client-api-messages" "core" "client-api" "standalone" "cli" "sdk")
+declare -a CRATES=("metrics" "primitives" "bindings-macro" "bindings-sys" "data-structures" "sats" "lib" "bindings" "table" "vm" "client-api-messages" "commitlog" "durability" "fs-utils" "snapshot" "core" "client-api" "standalone" "cli" "sdk")

@kurtismullins It's all the same crates as is in this PR. So to check - you started with the version of the script in the release branch (which is the same as the one in this PR), and it didn't work, so you had to reorder the crates to the version you have now?

@bfops
Copy link
Contributor Author

bfops commented Jun 14, 2024

declare -a CRATES=("metrics" "primitives" "bindings-macro" "bindings-sys" "data-structures" "sats" "lib" "bindings" "table" "vm" "client-api-messages" "commitlog" "durability" "fs-utils" "snapshot" "core" "client-api" "standalone" "cli" "sdk")

@kurtismullins Updated to your exact ordering

@bfops bfops requested a review from kurtismullins June 14, 2024 16:32
@bfops bfops enabled auto-merge June 14, 2024 16:34
@kurtismullins
Copy link
Collaborator

@bfops Here were the changes I ultimately needed to successfully publish to crates.io in the v0.10.0-beta tag. I haven't checked to see if they match yours in this PR; if so, feel free to let me know and I'll approve it so you can get it merged.
At the moment, I am shoulder-deep in this release.

-declare -a CRATES=("metrics" "primitives" "bindings-macro" "bindings-sys" "sats" "lib" "bindings" "vm" "client-api-messages" "core" "client-api" "standalone" "cli" "sdk")
+declare -a CRATES=("metrics" "primitives" "bindings-macro" "bindings-sys" "data-structures" "sats" "lib" "bindings" "table" "vm" "client-api-messages" "commitlog" "durability" "fs-utils" "snapshot" "core" "client-api" "standalone" "cli" "sdk")

@kurtismullins It's all the same crates as is in this PR. So to check - you started with the version of the script in the release branch (which is the same as the one in this PR), and it didn't work, so you had to reorder the crates to the version you have now?

I started with the script that was in the tag and had to add missing crates.

Copy link
Collaborator

@kurtismullins kurtismullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfops bfops added this pull request to the merge queue Jun 14, 2024
Merged via the queue into master with commit cceb8c0 Jun 14, 2024
8 checks passed
@bfops bfops deleted the bfops/update-crates branch June 14, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no runtime change This change does not affect the final binaries release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants