Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue which caused metrics to only be recorded for on-disk databases #901

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

cloutiertyler
Copy link
Contributor

@cloutiertyler cloutiertyler commented Feb 28, 2024

Description of Changes

Fixed an issue which caused metrics to only be recorded for on-disk databases.

Note to reviewer: I'm not sure that it makes sense to pass the ExecutionContext so deep, but this works.

API and ABI breaking changes

None

Expected complexity level and risk

2

Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tested this during a meeting using the bots, working from a functionality standpoint 👍

@bfops bfops added release-any To be landed in any release window bugfix Fixes something that was expected to work differently labels Mar 18, 2024
@cloutiertyler cloutiertyler added this pull request to the merge queue Mar 28, 2024
Merged via the queue into master with commit 01ba5cd Mar 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes something that was expected to work differently release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants