Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #[tracing::instrument...] from InstanceEnv::*_by_col_eq #983

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Remove #[tracing::instrument...] from InstanceEnv::*_by_col_eq #983

merged 3 commits into from
Mar 15, 2024

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Mar 15, 2024

Description of Changes

See diff.

cloutiertyler
cloutiertyler approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are removing tracing that happens way too often and has significant overhead.

iter_by_col_eq takes like 1.5 us and tracing takes most of that time 1.2 us or so according to tracy.

We are also adding in some high level tracing that runs much less often.

@Centril Centril enabled auto-merge March 15, 2024 01:05
@Centril Centril added this pull request to the merge queue Mar 15, 2024
Merged via the queue into master with commit 261373c Mar 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloutiertyler cloutiertyler cloutiertyler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Centril @cloutiertyler