Simplify update handling as per consistent filtering proposal #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
added a commit
to clockworklabs/SpacetimeDB
that referenced
this pull request
May 22, 2024
- Limit types as per proposal. - Add `Query` client-side SDK helper for API parity with server-side modules (on client-side it's a simple wrapper around Iter + Where). - Change return type of `FilterBy` to always be iterable, with new `FindBy` function for unique fields. - Simplify the way primary keys are handled - must go with clockworklabs/com.clockworklabs.spacetimedbsdk#93 for the client SDK counterpart.
2 tasks
RReverser
changed the title
5 tasks
RReverser
changed the title
jdetter
approved these changes
May 27, 2024
This helps to catch missing usings from the generator.
RReverser
added a commit
to clockworklabs/SpacetimeDB
that referenced
this pull request
May 28, 2024
- Limit types as per proposal. - Add `Query` client-side SDK helper for API parity with server-side modules (on client-side it's a simple wrapper around Iter + Where). - Change return type of `FilterBy` to always be iterable, with new `FindBy` function for unique fields. - Simplify the way primary keys are handled - must go with clockworklabs/com.clockworklabs.spacetimedbsdk#93 for the client SDK counterpart.
github-merge-queue bot
pushed a commit
to clockworklabs/SpacetimeDB
that referenced
this pull request
May 28, 2024
* Update C# codegen to consistent filtering rules - Limit types as per proposal. - Add `Query` client-side SDK helper for API parity with server-side modules (on client-side it's a simple wrapper around Iter + Where). - Change return type of `FilterBy` to always be iterable, with new `FindBy` function for unique fields. - Simplify the way primary keys are handled - must go with clockworklabs/com.clockworklabs.spacetimedbsdk#93 for the client SDK counterpart. * Add using for System.Linq * Update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
As a result of the consistent filtering rules proposal (clockworklabs/SpacetimeDB#1256), all equatable types are now natively equatable in C# as well.
This allows us to compare objects directly, without holding and comparing AlgebraicValue in the entries map as well, which has a bit of a domino effect and allows to optimise, simplify or even remove some parts of the SDK.
API
New filtering rules limit types on which filtering can be done, as well as change the return type of
FilterByfunctions to always be iterable.Requires SpacetimeDB PRs
clockworklabs/SpacetimeDB#1277