Functional LK3 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made LK3 reflect P/INSERT. Not sure if insert is a meaningful key to have or another modifier is better. The bool shift_key_pressed() routine could be changed to int mod_key_pressed() and return a non-zero value for modifier pressed.
Mihaylov93
reviewed
Jan 13, 2020
| const int pins[KEY_NUM] = {3, 6, 7, 8, 9, 10, 11, 12, 13, 0, 2, 3, 4, 6, 7}; | ||
| const int shift_pins[SHIFT_KEY_NUM] = {1, 5}; | ||
| const int pins[KEY_NUM] = {3, 6, 7, 8, 9, 10, 11, 12, 13, 0, 2, 3, 4, 5, 6, 7}; | ||
| const int shift_pins[SHIFT_KEY_NUM] = {1}; |
There was a problem hiding this comment.
As its now 1 value, should be an int instead of a vector of int.
const int shift_pin = 1 for example or a #define to save bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made LK3 reflect P/INSERT.
Not sure if insert is a meaningful key to have or another modifier is better.
The bool shift_key_pressed() routine could be changed to int mod_key_pressed() and return a non-zero value for modifier pressed.