Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce SSL on registration and profile pages #46

Closed
technomancy opened this issue May 12, 2012 · 5 comments
Closed

Enforce SSL on registration and profile pages #46

technomancy opened this issue May 12, 2012 · 5 comments
Labels

Comments

@technomancy
Copy link
Collaborator

Any page involving passwords should require SSL.

@xeqi
Copy link
Collaborator

xeqi commented May 12, 2012

https://github.com/cemerick/friend/#channel-security might be useful here.

@ato
Copy link
Collaborator

ato commented May 13, 2012

Good point, can't believe I missed that. In fact it would probably be best to require SSL for the entire webapp and make the session cookie SSL-only.

I've put in nginx redirects for /profile and /register in the meantime.

@xeqi
Copy link
Collaborator

xeqi commented May 17, 2012

Is this something that belongs in the app, or is it better handled at the nginx/proxy level?

@ato
Copy link
Collaborator

ato commented May 19, 2012

It's easy to put in redirect rules for SSL in nginx. But what's not easy to do in nginx is marking the session cookie SSL-only.

According to the ring wiki that's done like this:

(def app
  (wrap-session handler {:cookie-attrs {:secure true}}))

I also don't know what implications this has on Phil's Heroku plan though, as presumably that involves ditching nginx?

@ato
Copy link
Collaborator

ato commented May 26, 2012

I'm closing this particular issue as it's done for clojars.org itself: everything except GET on /repo now requires SSL. For the second phase of enforcing SSL in the webapp itself (for secure cookies, Heroku deployment etc) see #48.

@ato ato closed this as completed May 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants