Update with master #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the pom.xml at least.
curtis.io seems to be missing most of its content
Caused by implicitly using a private var.
The old version isn't compatible with newer jvms, I don't think.
Fixes TCHECK-14 Now it's mostly a basic menu of links.
The clojure dev sites got overhauled sometime in the last year.
They were confusing/misleadingly named. I kept `gen/nat` since it's used quite a lot, and added `gen/small-integer` for when you want negatives, but otherwise just described in the docstrings how to get the same behavior.
The first bigint generator, it explicitly specifies that it's bounded by a function of the `size` parameter; this is in contrast to earlier approaches I tried where for any given `size` the distribution would still be unbounded, but smeared differently. Describing the distribution in the name leaves room for later adding other bigint generators that behave differently. I didn't add it to cljs, since it's unclear what to generate there, and so ratio uses large-integer instead. It just ends up being doubles on cljs anyhow so that part doesn't matter much.
This is a sad workaround for the eternal problem that collections containing NaNs, when not `identical?`, cannot be `=`. The name is more generic as there could conceivably be other objects added to gen/any & friends that don't qualify for the equable variants, e.g. (Object.)s. The word "equatable" could arguably imply the wrong concept of "can be passed to =", but since everything can be passed to = in clojure (just like every object implements .equals on the jvm), I'm not worried about this.
Github pages interprets the {{ as a special syntax, and I don't know
how to make it not do that, so this is easier. It's a bit remarkable
that that only shows up in one place.
1) Add a doc page for version-specific API docs 2) Enumerate exactly which doc pages should be included in the codox output 3) Config for linking to the github source
Should fix the jenkins build.
I had updated the test so that it no longer intentionally excluded infinite doubles, which works fine on 1.9 and later; this change excuses failures involving infinite values on versions of clojure that don't have a syntax for infinity.
Wouldn't it be great if git had a mechanism for annotating old commit messages or something of that sort? Anyhow I noticed that commit 5e2734f has an incorrect commit message due to too much `git commit --amend`ing, and I wanted to at least say so in the git log. (So this commit doesn't have any associated changes) The wrong part is "rewrite ratio in terms of it" -- in reality, gen/ratio was left alone and gen/big-ratio was added (jvm only), documented as using `gen/size-bounded-bigint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.