[Fix #196] Rewritten dependencies polluting ns-list

Our own inlined deps, created by mranderson, as well as the inlined deps
from eastwood were polluting the result of the `ns-list` op.  These are
now filtered out.

This change improves all cider commands relying on a completing read of
some namespace e.g. `cider-browse-ns` and `cider-find-ns`

src/cider/nrepl/middleware/ns.clj

@@ -12,10 +12,19 @@
              [transport :as transport]])
   (:import java.util.jar.JarFile))
 
+(defn inlined-dependency?
+  [^String ns]
+  (or
+   ;; rewritten by mranderson
+   (.startsWith ns "deps.")
+   ;; rewritten by dolly
+   (.startsWith ns "eastwood.copieddeps")))
+
 (defn ns-list-clj []
   (->> (all-ns)
        (map ns-name)
        (map name)
+       (remove inlined-dependency?)
        (sort)))
 
 (defn ns-vars-clj [ns]

test/clj/cider/nrepl/middleware/ns_test.clj

@@ -1,11 +1,14 @@
 (ns cider.nrepl.middleware.ns-test
-  (:require [cider.nrepl.middleware.ns :refer [ns-list-clj ns-vars-clj]]
+  (:require [cider.nrepl.middleware.ns
+             :refer [ns-list-clj ns-vars-clj inlined-dependency?]]
             [cider.nrepl.test-session :as session]
             [cider.nrepl.test-transport :refer [messages test-transport]]
             [clojure.test :refer :all]))
 
-(deftest test-toogle-ns-list
-  (is (= (count (all-ns)) (count (ns-list-clj)))))
+(deftest test-toggle-ns-list
+  (is (= (count (all-ns))
+         (count
+          (remove inlined-dependency? (ns-list-clj))))))
 
 (deftest test-toogle-ns-vars
   (let [ns "clojure.core"]
@@ -18,7 +21,11 @@
 (deftest ns-list-integration-test
   (let [ns-list (:ns-list (session/message {:op "ns-list"}))]
     (is (sequential? ns-list))
-    (is (every? string? ns-list))))
+    (is (every? string? ns-list))
+    (testing "Removal of namespaces created by source rewriting"
+      (is (every? #(not (or (.startsWith % "deps.")
+                            (.startsWith % "eastwood.copieddeps")))
+                  ns-list)))))
 
 (deftest ns-vars-integration-test
   (let [ns-vars (:ns-vars (session/message {:op "ns-vars"