Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'With Immutant/WildFly' section #192

Merged
merged 1 commit into from
Apr 16, 2015

Conversation

tobias
Copy link
Contributor

@tobias tobias commented Apr 14, 2015

This fixes the section about working with a container that uses JBoss
modules - the issue actually doesn't affect Immutant users.

This fixes the section about working with a container that uses JBoss
modules - the issue actually *doesn't* affect Immutant users.
@bbatsov
Copy link
Member

bbatsov commented Apr 14, 2015

Btw, will this still be an issue after #183?

@tobias
Copy link
Contributor Author

tobias commented Apr 14, 2015

That's a good question. cider.nrepl.middleware.util.java/add-classpath! will still try to modify the AppClassLoader even with #183, but the code the user needs to use in-container needs to change. Since mranderson inlines dynapath, the require statement needs to change to:

(require '[deps.dynapath.v0v2v3.dynapath.dynamic-classpath :as cp])

since the the standard dynapath dep won't be available, and even if it is, we have to use the same one that cider-nrepl is using, since deps.dynapath.v0v2v3.dynapath.dynamic-classpath.DynamicClasspath and dynapath.dynamic-classpath.DynamicClasspath will be considered different protocols. In fact, this protocol difference will break Immutant, and cause AppClassLoader to be used again there as well.

Everything that uses dynapath now should be using v0.2.3 - would it be possible to not inline it? Have you seen conflicts with dynapath not inlined?

@bbatsov
Copy link
Member

bbatsov commented Apr 14, 2015

Everything that uses dynapath now should be using v0.2.3 - would it be possible to not inline it? Have you seen conflicts with dynapath not inlined?

Don't recall such a case. Guess we can remove it from the inlined deps. //cc @benedekfazekas

That said - maybe it doesn't make sense to inline the debugger as well, not that it doesn't have any third-party deps.

@benedekfazekas
Copy link
Member

of course. you just don't mark it with ^:source-deps meta. in fact not inlining debugger might "fix" the current problem with #183 too

bbatsov added a commit that referenced this pull request Apr 16, 2015
Update 'With Immutant/WildFly' section
@bbatsov bbatsov merged commit e650186 into clojure-emacs:master Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants