Implement the :here debug action #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "Return true if coordinate a comes before b. | ||
| Here, \"comes before\" means that a sexp at coord a is evaluated | ||
| before a sexp at coord b (assuming a trivial code-flow)." | ||
| [a b] |
There was a problem hiding this comment.
When speaking of coords I've always preferred x and y over a and b. :-)
|
Apart from the failing build - the code changes look good to me. |
This action takes a coords vector in the message, and tells the debugger to skip any breakpoints before that.
Malabarba
force-pushed
the
debug-here
branch
2 times, most recently
from
e7f293f
to
aebd72c
Compare
bbatsov
added a commit
that referenced
this pull request
Jan 17, 2016
Implement the :here debug action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a cider.el counterpart here: clojure-emacs/cider#1517