Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continue-all in conditional break. #664

Merged

Conversation

FiV0
Copy link
Contributor

@FiV0 FiV0 commented Feb 4, 2020

The :continue-all command was previously not
ignoring conditional breakpoints as in the
following code.

(for [i (range 10)]
#dbg ^{:break/when (even? i)}
(inc i))

Fixes #656.

Before submitting a PR make sure the following things have been done:

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing
  • The new code is not generating reflection warnings
  • You've updated the README (if adding/changing middleware)

The :continue-all command was previously not
ignoring conditional breakpoints as in the
following code.

(for [i (range 10)]
  #dbg ^{:break/when (even? i)}
  (inc i))
@bbatsov
Copy link
Member

bbatsov commented Feb 5, 2020

Thanks for tackling this! The code looks good. Just mention the bugfix in the changelog.

@FiV0 FiV0 force-pushed the fix-continue-all-conditional-break branch from 2eb4864 to 0dabf9d Compare February 5, 2020 10:28
@bbatsov bbatsov merged commit d474399 into clojure-emacs:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:continue-all does not skip form with :break/when metadata
2 participants