Complete local bindings for ClojureScript files #767
Conversation
Good catch, I had missed this myself. It might be good to add some comment about this in the code, as at a glance it seems weird to mix ClojureScript and Clojure completion sources. |
Do you mean in the definition of |
|
The former, although it probably won't hurt to expand the compliment source documentation at some point. |
| @@ -36,7 +36,8 @@ | |||
|
|
|||
| (def cljs-sources | |||
| "A list of ClojureScript completion sources for compliment." | |||
| [::suitable-sources/cljs-source]) | |||
| [::suitable-sources/cljs-source | |||
| :compliment.sources.local-bindings/local-bindings]) | |||
There was a problem hiding this comment.
Basically when I saw this line my first reaction was "how can this possibly work?". 😆
There was a problem hiding this comment.
Comment added (and PR updated)
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| * [#766](https://github.com/clojure-emacs/cider-nrepl/issues/766) Complete local bindings for ClojureScript files. | |||
There was a problem hiding this comment.
This should be under "New features".
When editing a ClojureScript file, cider-nrepl doesn't offer any local binding names (the function name and argument names if inside the function, the let-like block bindings if inside a let-like block, etc.) as completion candidates, like it does when editing a Clojure file. The root of the problem is that `cider.nrepl.middleware.complete/cljs-sources` only includes `::suitable-sources/cljs-source` as a possible source. And `suitable` doesn't perform any local binding analysis. Given that the local binding analysis done in `compliment.sources.local-bindings` namespace doesn't perform any evaluation or execution of the context form (thus, it is independent of the actual host platform differences), we can use that same source for ClojureScript local bindings completion. [Closes: clojure-emacs#766]
|
Thanks! |
|
@iarenaza I've cut a new release including your change (0.30) and I've updated CIDER's |
Great! |
When editing a ClojureScript file, cider-nrepl doesn't offer any local binding names (the function name and argument names if inside the function, the let-like block bindings if inside a let-like block, etc.) as completion candidates, like it does when editing a Clojure file.
The root of the problem is that
cider.nrepl.middleware.complete/cljs-sourcesonly includes::suitable-sources/cljs-sourceas a possible source. Andsuitabledoesn't perform any local binding analysis.Given that the local binding analysis done in
compliment.sources.local-bindingsnamespace doesn't perform any evaluation or execution of the context form (thus, it is independent of the actual host platform differences), we can use that same source for ClojureScript local bindings completion.[Closes: #766]
Before submitting a PR make sure the following things have been done:
Thanks!