Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run checkdoc automatically for PRs #1072

Closed
bbatsov opened this issue Apr 6, 2015 · 4 comments
Closed

Run checkdoc automatically for PRs #1072

bbatsov opened this issue Apr 6, 2015 · 4 comments

Comments

@bbatsov
Copy link
Member

bbatsov commented Apr 6, 2015

We should invoke checkdoc on PRs to avoid the need for tickets like #1071.

Setting this up in travis should not be too complex.

@EricGebhart
Copy link
Contributor

Do you really want to just turn it on? If cider-interaction.el is any indication there are going to be a lot of errors everywhere. There were 50 in cider-interaction, I cleaned up dozens of them and ended up with 46. I suppose it will at least make everyone look and not introduce new errors.

@bbatsov
Copy link
Member Author

bbatsov commented Apr 7, 2015

Obviously we'll have to fix #1070 first. When the project was starting out there was a time when the entire codebase was checkdoc-compliant. There was also a Travis check for the docstrings. I had to turn it off for a reason I don't recall right now and afterwards I forgot to restore it.

@bbatsov
Copy link
Member Author

bbatsov commented Apr 7, 2015

Reference to the old check - https://github.com/clojure-emacs/cider/pull/262/files

Probably I removed it when I migrated the project to cask.

@bbatsov
Copy link
Member Author

bbatsov commented Oct 2, 2016

Duplicate of #1352.

@bbatsov bbatsov closed this as completed Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants