Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cider-connect-clj&cljs results in no clj repl connected #2519

Closed
kommen opened this issue Nov 15, 2018 · 5 comments
Closed

cider-connect-clj&cljs results in no clj repl connected #2519

kommen opened this issue Nov 15, 2018 · 5 comments

Comments

@kommen
Copy link
Contributor

kommen commented Nov 15, 2018

Expected behavior

cider-connect-clj&cljs connects a clj and a cljs repl

Actual behavior

cider-connect-clj&cljs connects, but the result is a cljs and a pending-cljs repl. So it looks like the wrong repl is turned into cljs.

The same issue happens when first cider-connect-clj, and then cider-connect-sibling-cljs.

Steps to reproduce the problem

Just cider-connect-clj&cljs

Environment & Version information

CIDER version information

Include here the version string displayed when
CIDER's REPL is launched. Here's an example:

;; CIDER 0.19.0snapshot (package: 20181110.1413), nREPL 0.2.13
;; Clojure 1.9.0, Java 1.8.0_31

Emacs version

26.1

Operating system

macOS 10.14.1

Commments

This is a very recent regression, so timing wise it looks like #2516 could be the culprit, but I didn't verify that yet.

@glittershark
Copy link
Contributor

@kommen can you see if the patch in #2515 fixes this? This smells like a similar problem from what I was encountering

@kommen
Copy link
Contributor Author

kommen commented Nov 15, 2018

@glittershark thanks, I tried and the patch there doesn't fix my issue.

@kommen
Copy link
Contributor Author

kommen commented Nov 15, 2018

Tracked it down and it seems to be a regression of 5624cb5

@kommen
Copy link
Contributor Author

kommen commented Nov 15, 2018

The issue seems to be fixed in #2484

@kommen
Copy link
Contributor Author

kommen commented Nov 19, 2018

Fixed with #2484

@kommen kommen closed this as completed Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants