Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clj-refactor customize support is missing a defgroup form #482

Closed
pierre-rouleau opened this issue Mar 10, 2021 · 6 comments
Closed

clj-refactor customize support is missing a defgroup form #482

pierre-rouleau opened this issue Mar 10, 2021 · 6 comments

Comments

@pierre-rouleau
Copy link
Contributor

Expected behavior

When using M-x customize-group cljr, you should be able to see the group's parent.

Actual behavior

The cljr customize buffer shows: "Group definition missing." instead.

Steps to reproduce the problem

  • M-x customize-group cljr
  • Read line 9 where the message shows.

Environment & Version information

Not relevant here, but tested on Emacs 26.3 on macOS Mojave.

clj-refactor.el version information

clj-refactor 2.5.1 (package: 20210216.928)

CIDER version information

N/A.

Leiningen or Boot version

N/A.

Emacs version

Emacs 26.3

Operating system

macOS Mojave

Extra Notes

I can submit a pull-request with the fix.

@pierre-rouleau pierre-rouleau changed the title cli-refactor customize support mis missing a defgroup form clj-refactor customize support mis missing a defgroup form Mar 11, 2021
@pierre-rouleau
Copy link
Contributor Author

I would solve this with the following change: pierre-rouleau@f735d09

@pierre-rouleau pierre-rouleau changed the title clj-refactor customize support mis missing a defgroup form clj-refactor customize support is missing a defgroup form Mar 11, 2021
@bbatsov
Copy link
Member

bbatsov commented Mar 11, 2021

Looks good. Guess we overlooked this.

@pierre-rouleau
Copy link
Contributor Author

I'll submit later today after I have time to setup an environment with Emacs 27 and cask to be able to run your tests

@bbatsov
Copy link
Member

bbatsov commented Mar 11, 2021

For such a simple change that's not really needed. I'm sure it won't break anything.

@pierre-rouleau
Copy link
Contributor Author

I thought so too, but since I never submitted anything here, I was going to play nice. So OK, I'll go ahead and submit. There's so little time and soooo many things to do...
BTW. Thanks for all of these Clojure projects!

@bbatsov
Copy link
Member

bbatsov commented Mar 11, 2021

I thought so too, but since I never submitted anything here, I was going to play nice. So OK, I'll go ahead and submit. There's so little time and soooo many things to do...

I know what you mean. 😄

BTW. Thanks for all of these Clojure projects!

You're welcome! Btw, you finally pushed me to update the CI build of the project, so at least people can get some feedback on their PRs without having to setup the test developments locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants