Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build #491

Closed
expez opened this issue Jun 28, 2021 · 3 comments
Closed

Fix the build #491

expez opened this issue Jun 28, 2021 · 3 comments

Comments

@expez
Copy link
Member

expez commented Jun 28, 2021

Looks like two things are going on:

  1. One actual test failure for emacs versions 26 and 27.
  2. Test check validating grammar etc

Can we turn off test check? I'd rather have a green build badge giving an indication that this lib is alive and kicking.
Furthermore, with limited time available I'd much rather fix actual bugs than go over 3k lines of code to make sure e.g. error messages don't end in a period.

@bbatsov
Copy link
Member

bbatsov commented Jun 28, 2021

I'd disable the offending test as the quickest solution. I'm also fine with disabling checkdoc, although it's not grammar check. Still, it's not something particularly important.

@bbatsov
Copy link
Member

bbatsov commented Jun 28, 2021

Btw, when I checked the CI I saw that only the one test if failing.

vemv added a commit that referenced this issue Jul 9, 2021
bbatsov added a commit that referenced this issue Sep 30, 2021
@vemv
Copy link
Member

vemv commented Mar 15, 2022

I'd disable the offending test as the quickest solution.

(We did so)

@vemv vemv closed this as completed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants