Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement commands for navigating over logical sexps #302

Merged
merged 1 commit into from Jun 30, 2015
Merged

Implement commands for navigating over logical sexps #302

merged 1 commit into from Jun 30, 2015

Conversation

Malabarba
Copy link
Member

@@ -1044,6 +1044,45 @@ Returns a list pair, e.g. (\"defn\" \"abc\") or (\"deftest\" \"some-test\")."
(list (match-string 1)
(match-string 2))))))


;;; Sexp navigation
(defun clojure-mode-forward-logical-sexp (&optional n)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major mode commands generally don't have mode in their names.

@bbatsov
Copy link
Member

bbatsov commented Jun 30, 2015

This also needs a changelog entry.

@Malabarba
Copy link
Member Author

Done

bbatsov added a commit that referenced this pull request Jun 30, 2015
Implement commands for navigating over logical sexps
@bbatsov bbatsov merged commit 43c7f09 into clojure-emacs:master Jun 30, 2015
@bbatsov
Copy link
Member

bbatsov commented Jun 30, 2015

👍 Looks good! Guess now you can do the changes required for clojure-emacs/cider#1171 as well. :-)

@Malabarba
Copy link
Member Author

Yep. I'll change the debugger to use these too instead of implementing its own.

@ryfow
Copy link

ryfow commented Jul 2, 2015

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants